[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/1] virtio: serial: expose a 'guest_writable
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/1] virtio: serial: expose a 'guest_writable' callback for users |
Date: |
Thu, 13 Nov 2014 15:47:12 +0100 |
On Di, 2014-10-28 at 20:21 +0530, Amit Shah wrote:
> Users of virtio-serial may want to know when a port becomes writable. A
> port can stop accepting writes if the guest port is open but not being
> read from. In this case, data gets queued up in the virtqueue, and
> after the vq is full, writes to the port do not succeed.
>
> When the guest reads off a vq element, and adds a new one for the host
> to put data in, we can tell users the port is available for more writes,
> via the new ->guest_writable() callback.
>
> Signed-off-by: Amit Shah <address@hidden>
What is the plan with that one? I have some spice patches sitting in a
branch depending on this one. Should it go through virtio queue? With
some ack from virtio I can also take it through the spice queue,
together with the other patches depending on this one.
It fails checkpatch btw:
=== checkpatch complains ===
ERROR: code indent should never use tabs
#53: FILE: include/hw/virtio/virtio-serial.h:102:
+^I * Guest has enqueued a buffer for the host to write into.$
[ ... more of these snipped ... ]
cheers,
Gerd
- Re: [Qemu-devel] [PATCH v3 1/1] virtio: serial: expose a 'guest_writable' callback for users,
Gerd Hoffmann <=