[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] mips/gdbstub: Make CP1.FIR read-only here too
|
From: |
Leon Alrae |
|
Subject: |
Re: [Qemu-devel] [PATCH] mips/gdbstub: Make CP1.FIR read-only here too |
|
Date: |
Fri, 14 Nov 2014 09:24:18 +0000 |
|
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 03/11/2014 18:51, Maciej W. Rozycki wrote:
> CP1.FIR is read-only in hardware so gdbstub must respect it. We already
> respect it for CTC1 instructions, so do it here too.
>
> Signed-off-by: Maciej W. Rozycki <address@hidden>
> ---
> Not much to say about it here. Please apply.
>
> Maciej
>
> qemu-mips-fir.diff
> Index: qemu-git-trunk/target-mips/gdbstub.c
> ===================================================================
> --- qemu-git-trunk.orig/target-mips/gdbstub.c 2014-11-02 17:51:33.458968203
> +0000
> +++ qemu-git-trunk/target-mips/gdbstub.c 2014-11-02 17:51:35.958924223
> +0000
> @@ -112,7 +112,7 @@ int mips_cpu_gdb_write_register(CPUState
> RESTORE_ROUNDING_MODE;
> break;
> case 71:
> - env->active_fpu.fcr0 = tmp;
> + /* FIR is read-only. Ignore writes. */
> break;
> }
> return sizeof(target_ulong);
>
Reviewed-by: Leon Alrae <address@hidden>