[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vmdk: Leave bdi intact if -ENOTSUP in vmdk_get_
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] vmdk: Leave bdi intact if -ENOTSUP in vmdk_get_info |
Date: |
Fri, 14 Nov 2014 09:29:12 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Nov 14, 2014 at 12:09:21PM +0800, Fam Zheng wrote:
> When extent types don't match, we return -ENOTSUP. In this case, be
> polite to the caller and don't modify bdi.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block/vmdk.c | 20 +++++++++++++-------
> 1 file changed, 13 insertions(+), 7 deletions(-)
At this stage of the release process it would be very helpful to include
some context for this patch: is it a pure cleanup or actually a bug fix
that needs to go into QEMU 2.2?
Since you are a regular contributor and I therefore trust you, I have
merged this patch. But please be clear in commit descriptions about
whether or not a patch is a bug fix (how to reproduce the bug, if a
previous commit's regression is being fixed, etc).
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
pgpcvbKdRBQz1.pgp
Description: PGP signature