Re: [Qemu-devel] [PATCH 2.3 8/8] tcg: Remove unused opcodes

[Bastian Koppelmann]

On 11/11/2014 04:24 PM, Richard Henderson wrote:
> diff --git a/tci.c b/tci.c
> index 4711ee4..28292b3 100644
> --- a/tci.c
> +++ b/tci.c
> @@ -506,19 +506,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t 
> *tb_ptr)
>           tb_ptr += 2;
>   
>           switch (opc) {
> -        case INDEX_op_end:
> -        case INDEX_op_nop:
> -            break;
> -        case INDEX_op_nop1:
> -        case INDEX_op_nop2:
> -        case INDEX_op_nop3:
> -        case INDEX_op_nopn:
> -        case INDEX_op_discard:
> -            TODO();
> -            break;
> -        case INDEX_op_set_label:
> -            TODO();
> -            break;
Why do you remove the TODO notice for INDEX_op_discard/set_label? Is TCI 
no longer maintained?
>           case INDEX_op_call:
>               t0 = tci_read_ri(&tb_ptr);
>   #if TCG_TARGET_REG_BITS == 32
Other than that,

Reviewed-by: Bastian Koppelmann <address@hidden>

Cheers,
Bastian