[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 11/21] iotests: Prepare for refcount_width op
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 11/21] iotests: Prepare for refcount_width option |
Date: |
Sat, 15 Nov 2014 10:17:49 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 11/14/2014 06:06 AM, Max Reitz wrote:
> Some tests do not work well with certain refcount widths (i.e. you
> cannot create internal snapshots with refcount_width=1), so make those
> widths unsupported.
>
> Furthermore, add another filter to _filter_img_create in common.filter
> which filters out the refcount_width value.
>
> This is necessary for test 079, which does actually work with any
> refcount width, but invoking qemu-img directly leads to the
> refcount_width value being visible in the output; use _make_test_img
> instead which will filter it out.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> +++ b/tests/qemu-iotests/029
> @@ -44,6 +44,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
> _supported_fmt qcow2
> _supported_proto generic
> _supported_os Linux
> +_unsupported_imgopts 'refcount_width=1[^0-9]'
Missed a comment here.
> +++ b/tests/qemu-iotests/common.filter
> @@ -190,7 +190,8 @@ _filter_img_create()
> -e "s# block_size=[0-9]\\+##g" \
> -e "s# block_state_zero=\\(on\\|off\\)##g" \
> -e "s# log_size=[0-9]\\+##g" \
> - -e "s/archipelago:a/TEST_DIR\//g"
> + -e "s/archipelago:a/TEST_DIR\//g" \
> + -e "s# refcount_width=[0-9]\\+##g"
I'm not convinced that \+ is portable sed; but as you are not the first
use, it's not worth changing.
Once you add the remaining comment,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 06/21] qcow2: Helper for refcount array reallocation, (continued)
- [Qemu-devel] [PATCH v2 07/21] qcow2: Helper function for refcount modification, Max Reitz, 2014/11/14
- [Qemu-devel] [PATCH v2 08/21] qcow2: More helpers for refcount modification, Max Reitz, 2014/11/14
- [Qemu-devel] [PATCH v2 09/21] qcow2: Open images with refcount order != 4, Max Reitz, 2014/11/14
- [Qemu-devel] [PATCH v2 11/21] iotests: Prepare for refcount_width option, Max Reitz, 2014/11/14
- Re: [Qemu-devel] [PATCH v2 11/21] iotests: Prepare for refcount_width option,
Eric Blake <=
- [Qemu-devel] [PATCH v2 12/21] qcow2: Allow creation with refcount order != 4, Max Reitz, 2014/11/14
- [Qemu-devel] [PATCH v2 10/21] qcow2: refcount_order parameter for qcow2_create2, Max Reitz, 2014/11/14
- [Qemu-devel] [PATCH v2 13/21] block: Add opaque value to the amend CB, Max Reitz, 2014/11/14
- [Qemu-devel] [PATCH v2 15/21] qcow2: Use abort() instead of assert(false), Max Reitz, 2014/11/14
- [Qemu-devel] [PATCH v2 16/21] qcow2: Split upgrade/downgrade paths for amend, Max Reitz, 2014/11/14
- [Qemu-devel] [PATCH v2 14/21] qcow2: Use error_report() in qcow2_amend_options(), Max Reitz, 2014/11/14
- [Qemu-devel] [PATCH v2 17/21] qcow2: Use intermediate helper CB for amend, Max Reitz, 2014/11/14
- [Qemu-devel] [PATCH v2 18/21] qcow2: Add function for refcount order amendment, Max Reitz, 2014/11/14