Re: [Qemu-devel] [PATCH 0/4] migration: fix CVE-2014-7840

[Amit Shah]

On (Mon) 17 Nov 2014 [12:32:57], Michael S. Tsirkin wrote:
> On Mon, Nov 17, 2014 at 12:06:38PM +0530, Amit Shah wrote:
> > On (Wed) 12 Nov 2014 [11:44:35], Michael S. Tsirkin wrote:
> > > This patchset fixes CVE-2014-7840: invalid
> > > migration stream can cause arbitrary qemu memory
> > > overwrite.
> > > First patch includes the minimal fix for the issue.
> > > Follow-up patches on top add extra checking to reduce the
> > > chance this kind of bug recurs.
> > > 
> > > Note: these are already (tentatively-pending review)
> > > queued in my tree, so only review/ack
> > > is necessary.
> > 
> > Why not let this go in via the migration tree?
> 
> Well I Cc'd Juan and David, so if they had a problem with this, I expect
> they'd complain.  David acked so I assume it's ok.  Since I wasted time
> testing this and have it on my tree already, might as well just merge.

IMO asking as a courtesy would've been better than just stating it.

> Which reminds me: we really should have someone in MAINTAINERS
> for migration-related files.

There is, since last week.


                Amit