Re: [Qemu-devel] [PATCH v10 17/26] target-arm: make TTBCR banked

[Peter Maydell]

On 6 November 2014 15:51, Greg Bellows <address@hidden> wrote:
> From: Fabian Aggeler <address@hidden>
>
> Adds secure and non-secure bank register suport for TTBCR.
> Added new struct to compartmentalize the TCR data and masks.  Removed old
> tcr/ttbcr data and added a 4 element array of the new structs in cp15.  This
> allows for one entry per EL.  Added a CP register definition for TCR_EL3.
>
> Signed-off-by: Fabian Aggeler <address@hidden>
> Signed-off-by: Greg Bellows <address@hidden>

> +static void *raw_ptr(CPUARMState *env, const ARMCPRegInfo *ri)
> +{
> +    return (char *)(env) + (ri)->fieldoffset;
> +}

You don't need the brackets round "ri" here, since this isn't
a macro.

> +    /* Get the TCR bank based on our security state*/

Missing space before "*/".

Otherwise
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM