[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/5] block: Add AioContextNotifier functions to
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/5] block: Add AioContextNotifier functions to BB |
|
Date: |
Tue, 18 Nov 2014 10:44:52 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 18/11/2014 10:26, Max Reitz wrote:
> However, when you consider (as far as I looked into it) that a BDS is
> only closed when there are either no references to it (which will not
> happen as long as it has a BB) or when it is ejected, it suddenly does
> make sense: "Ejecting" really is something for the BB, so it makes sense
> to wait for that event (even though the name "close notifier" doesn't
> sound much like it...).
I agree, and indeed the notifier was added to deal with ejection.
Thanks for clarifying. I guess if QEMU were written in C++ we would
have a hierarchy like this:
BlockDevice (abstract)
BlockBackend
BlockDriverState
and there would be no duplication of function names; the BlockBackend
implementation would still have to forward to the top BlockDriverState.
Paolo