[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Tracing: Fix simpletrace.py error on tcg enable
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] Tracing: Fix simpletrace.py error on tcg enabled binary traces |
|
Date: |
Tue, 18 Nov 2014 14:05:40 +0000 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Nov 17, 2014 at 07:57:08PM -0600, Lluís Vilanova wrote:
> Stefan Hajnoczi writes:
>
> > On Sun, Nov 02, 2014 at 10:37:59PM +0100, address@hidden wrote:
> >> From: Christoph Seifert <address@hidden>
> >>
> >> simpletrace.py does not recognize the tcg option while reading trace-events
> >> file. In result simpletrace does not work on binary traces and tcg enabled
> >> events. Moved transformation of tcg enabled events to _read_events() which
> >> is
> >> used by simpletrace.
> >>
> >> Signed-off-by: Christoph Seifert <address@hidden>
> >> ---
> >> scripts/tracetool/__init__.py | 67
> >> +++++++++++++++++++++----------------------
> >> 1 file changed, 33 insertions(+), 34 deletions(-)
>
> > Looks good to me.
>
> > Lluís: Any comments?
>
> I've looked at how it affects some patches I did not have time yet to send,
> and
> everything looks good.
Fantastic, thanks for your time, Lluís!
Stefan
pgpBRhHhKRkHl.pgp
Description: PGP signature