Re: [Qemu-devel] [PATCH v2] Pass semihosting exit code back to system.

[Liviu Ionescu]

On 18 Nov 2014, at 23:19, Paolo Bonzini <address@hidden> wrote:

> The isa-debugexit and testdev character device do not exit with exitcode
> 0, in order to distinguish an exit from a system power down; the
> low-order bit is always 1.  The return values then should be 1 and 3
> instead of 0 and 1.

I have no experience with the isa-debugexit and testdev character device, and 
if there is any relationship between them and the semihosting code, but the 
original code always returned 0, regardless of the value passed by 
TARGET_SYS_EXIT, so I doubt there are any existing use cases that expect the 
semihosting code to return 1 or 3. 

in addition to passing trace messages, the main use of the semihosting calls is 
to run unit tests, and all automated testing infrastructures assumes the test 
executables to return 0/non-zero, as any well behaved POSIX processes.

I personally would not change this.

regards,

Liviu