[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] spice: remove spice-experimental.h include
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH] spice: remove spice-experimental.h include |
Date: |
Wed, 19 Nov 2014 10:55:14 +0100 |
On Mo, 2014-11-17 at 20:19 +0300, Michael Tokarev wrote:
> 17.11.2014 18:52, Marc-André Lureau wrote:
> > Nothing seems to be using functions from spice-experimental.h (better
> > that way). Let's remove its inclusion.
>
> Is it with current spice, or with some older spice too?
> I mean, why this include has been added to start with -- was it
> because of some feature which initially was only in -experimental.h
> but later moved to main spice? If yes, it'd be interesting to see
> when, in which version of spice, that has been done. Or at least
> to verify that the minimal version of spice required by qemu (in
> configure) allows to stop including -experimental.h....
>
> So basically, my only question here is -- what version of spice
> did you check -- especially, did you check the current minimal
> required version too?
minimum required spice-server is 0.12.0. IIRC the char channel stuff
used to be in experimental, but I think that predates 0.12.0. Marc?
cheers,
Gerd