[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration: static variables will not be reset a
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH] migration: static variables will not be reset at second migration |
Date: |
Thu, 20 Nov 2014 12:35:54 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
* Amit Shah (address@hidden) wrote:
> On (Thu) 20 Nov 2014 [19:39:11], Gonglei wrote:
> > >>>> The static variables in migration_bitmap_sync will not be reset in
> > >>>> the case of a second attempted migration.
> > >>>>
> > >>>> Signed-off-by: ChenLiang <address@hidden>
> > >>>> Signed-off-by: Gonglei <address@hidden>
> > >>>
> > >>> Good catch. Applied..
> > >>>
> > >>
> > >> Hi, Juan? Ping... please :)
> > >
> > > Juan, what happened to this patch?
> >
> > Nearly for half a year, I forgot it completely :(
> > Thanks for your prompt, Paolo.
>
> Yeah; unfortunate.
>
> I feel the patch could've been done in a better way, but since it's
> been a while...
>
> Paolo, Dave, can you please give me r-b and I'll pick it up for 2.2.
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Note that there are some more statics that have ended up in
migration_bitmap_sync
since that patch landed, but still it would be good to get this fix going.
Dave
>
> Thanks,
>
> Amit
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
Re: [Qemu-devel] [PATCH] migration: static variables will not be reset at second migration, Dr. David Alan Gilbert, 2014/11/20