Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 v3 1/1] -machine vmport=auto: Fix handling of VMWare ioport emulation for xen

[Eduardo Habkost]

On Thu, Nov 20, 2014 at 10:16:37AM -0500, Don Slutz wrote:
> On 11/20/14 04:13, Michael S. Tsirkin wrote:
> >On Wed, Nov 19, 2014 at 09:11:41PM -0700, Eric Blake wrote:
[...]
> >>>+{ 'enum': 'vmport',
> >>All other enums in .json files are named in StudlyCaps.  Please name
> >>this starting with a capital letter, and reserve all-lower-case names
> >>for commands and built-in types.
> >Hi Eric,
> >The values here are not vmport-specific.
> >Do you think we should have a generic OnOffAuto type?
> >
> 
> I am waiting for a a clear direction on how to go.
> 
> VMPortConfig, Tristate, and OnOffAuto are the 3 names
> I am tracking.

I prefer a non-vmport-specific name. OnOffAuto is more descriptive than
Tristate, and is good enough to me.

-- 
Eduardo