[Qemu-devel] [PATCH 2/4] blockdev: drop unnecessary DriveBackupState field assignment

[Stefan Hajnoczi]

drive_backup_prepare() assigns DriveBackupState fields to NULL in the
error path.  This is unnecessary because the DriveBackupState is
allocated using g_malloc0() and other functions like
external_snapshot_prepare() already rely on this.

Do not explicitly assign fields to NULL so that the error path is
concise and does not require modification when fields are added to
DriveBackupState.

Signed-off-by: Stefan Hajnoczi <address@hidden>
---
 blockdev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/blockdev.c b/blockdev.c
index 778509b..0d06983 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1475,8 +1475,6 @@ static void drive_backup_prepare(BlkTransactionState 
*common, Error **errp)
                      &local_err);
     if (local_err) {
         error_propagate(errp, local_err);
-        state->bs = NULL;
-        state->job = NULL;
         return;
     }
 
-- 
2.1.0