Re: [Qemu-devel] [PATCH v4 4/4] target-tricore: Add instructions of RCR opcode format

[Richard Henderson]

On 11/21/2014 04:31 PM, Bastian Koppelmann wrote:
> Add instructions of RCR opcode format.
> Add helper for madd32/64_ssov and madd32/64_suov.
> Add helper for msub32/64_ssov and msub32/64_suov.
> Add microcode generator function madd/msub for 32bit and 64bit, which 
> calculate a mul and a add/sub.
> OPC2_32_RCR_MSUB_U_32 -> OPC2_32_RCR_MSUB_U_32.
> 
> Signed-off-by: Bastian Koppelmann <address@hidden>
> ---
> v3 -> v4:
>     - helper madd64_ssov/suov and msub64_ssov/suov now use 64 bit arithmetic 
> for the add. (Thanks alot, Richard!)

Reviewed-by: Richard Henderson <address@hidden>


r~