[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/3] linux-aio: fix submit aio as a batch
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 1/3] linux-aio: fix submit aio as a batch |
|
Date: |
Mon, 24 Nov 2014 11:09:52 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 24/11/2014 11:02, Ming Lei wrote:
>> > Right, but "-1" is "-EPERM" which doesn't make much sense. I think the
>> > right thing to do is to return EAGAIN, and let the owner figure it out.
>> > For example, a SCSI device might return a "BUSY" status code.
> We can do that, but laio_submit() doesn't return the code to callers.
That can be fixed later. But not returning a sensible errno only makes
things more complicated later on.
Paolo
[Qemu-devel] [PATCH v3 2/3] linux-aio: handling -EAGAIN for !s->io_q.plugged case, Ming Lei, 2014/11/06
[Qemu-devel] [PATCH v3 3/3] linux-aio: remove 'node' from 'struct qemu_laiocb', Ming Lei, 2014/11/06