Re: [Qemu-devel] [PATCH for-2.2] Revert "qemu-img info: show nocow info"

[Stefan Hajnoczi]

On Fri, Nov 21, 2014 at 06:05:30PM +0100, Kevin Wolf wrote:
> This reverts commit 000c4dfff4d7686e2fba3066a477a1290ed60622.
> 
> The main reason for reverting this commit before the 2.2 release is that
> it adds a QAPI interface that we don't want to keep: The 'nocow' flag
> doesn't generally make sense for block nodes, but only for the raw-posix
> driver. It should therefore be part of ImageInfoSpecific rather than
> ImageInfo.
> 
> The commit contains more problems, but unlike the API stability issue
> they wouldn't justify reverting it.
> 
> Conflicts:
>       block/qapi.c
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/qapi.c         | 26 --------------------------
>  qapi/block-core.json |  5 +----
>  2 files changed, 1 insertion(+), 30 deletions(-)

Sorry for merging this prematurely, I agree with your points.

Reviewed-by: Stefan Hajnoczi <address@hidden>

pgpezL3q9hn8_.pgp
Description: PGP signature