Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 1/1] hw/ide/core.c: Prevent SIGSEGV during migration

[Markus Armbruster]

"Dr. David Alan Gilbert" <address@hidden> writes:

> * Don Slutz (address@hidden) wrote:
>> On 11/21/14 05:49, Dr. David Alan Gilbert wrote:
>> >* Markus Armbruster (address@hidden) wrote:
[...]
>> >>Management tools should use -nodefaults.  But if it mixes default and
>> >>-nodefaults in migration, recreating the stuff it got by default but
>> >>doesn't get with -nodefaults is its own responsibility.
>> 
>> Yes. Since xen did not ask for a CD-ROM, it did not expect to need to create
>> it.   xen was "fixed" to use -nodefaults.
>> 
>> >Well, mostly - we wouldn't expect a migration to work if the source/dest
>> >didn't match exactly; but QEMU shouldn't seg.
>> 
>> Well, this change prevents a seg.  So you are in favor of having this
>> backported?
>
> Yes.

I gladly defer to Dave's judgement here.