qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 3/3] block: Don't probe for unknown backing f


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v2 3/3] block: Don't probe for unknown backing file format
Date: Tue, 25 Nov 2014 18:24:59 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0

On 2014-11-25 at 18:12, Kevin Wolf wrote:
If a qcow2 image specifies a backing file format that doesn't correspond
to any format driver that qemu knows, we shouldn't fall back to probing,
but simply error out.

Not looking up the backing file driver in bdrv_open_backing_file(), but
just filling in the "driver" option if it isn't there moves us closer to
the goal of having everything in QDict options and gets us the error
handling of bdrv_open(), which correctly refuses unknown drivers.

Cc: address@hidden
Signed-off-by: Kevin Wolf <address@hidden>
---
  block.c                    |  7 +++---
  tests/qemu-iotests/114     | 61 ++++++++++++++++++++++++++++++++++++++++++++++
  tests/qemu-iotests/114.out | 13 ++++++++++
  tests/qemu-iotests/group   |  1 +
  4 files changed, 78 insertions(+), 4 deletions(-)
  create mode 100755 tests/qemu-iotests/114
  create mode 100644 tests/qemu-iotests/114.out

Reviewed-by: Max Reitz <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]