Re: [Qemu-devel] [PATCH 1/2] balloon: call qdev_alias_all_properties for proxy dev in balloon class init

[Denis V. Lunev]

On 26/11/14 15:27, Cornelia Huck wrote:
> On Wed, 26 Nov 2014 13:11:24 +0300
> "Denis V. Lunev" <address@hidden> wrote:
>
> > From: Raushaniya Maksudova <address@hidden>
> >
> > The idea is that all other virtio devices are calling this helper
> > to merge properties of the proxy device. This is the only difference
> > in between this helper and code in inside virtio_instance_init_common.
> > The patch should not cause any harm as property list in generic balloon
> > code is empty.
> >
> > This also allows to avoid some dummy errors like fixed by this
> >      commit 91ba21208839643603e7f7fa5864723c3f371ebe
> >      Author: Gonglei <address@hidden>
> >      Date:   Tue Sep 30 14:10:35 2014 +0800
> >      virtio-balloon: fix virtio-balloon child refcount in transports
> >
> > Signed-off-by: Denis V. Lunev <address@hidden>
> > Acked-by: Raushaniya Maksudova <address@hidden>
> > CC: Cornelia Huck <address@hidden>
> > CC: Christian Borntraeger <address@hidden>
> > CC: Anthony Liguori <address@hidden>
> > CC: Michael S. Tsirkin <address@hidden>
> > ---
> >   hw/s390x/virtio-ccw.c  | 5 ++---
> >   hw/virtio/virtio-pci.c | 5 ++---
> >   2 files changed, 4 insertions(+), 6 deletions(-)
> Shouldn't this have the sign-off of the author (rather than the ack) as
> well?
>
> Otherwise, looks sane.
I am an original author of the patch and prepared it to Rushana
to pass command line options for her next patch. I'll fix this
line in the next submission.