Re: [Qemu-devel] [PATCH v8 01/10] qapi: Add optional field "name" to block dirty bitmap

[Max Reitz]

On 2014-11-26 at 18:41, John Snow wrote:
> From: Fam Zheng <address@hidden>
>
> This field will be set for user created dirty bitmap. Also pass in an
> error pointer to bdrv_create_dirty_bitmap, so when a name is already
> taken on this BDS, it can report an error message. This is not global
> check, two BDSes can have dirty bitmap with a common name.
>
> Implemented bdrv_find_dirty_bitmap to find a dirty bitmap by name, will
> be used later when other QMP commands want to reference dirty bitmap by
> name.
>
> Add bdrv_dirty_bitmap_make_anon. This unsets the name of dirty bitmap.
>
> Signed-off-by: Fam Zheng <address@hidden>
> Signed-off-by: John Snow <address@hidden>
> ---
>   block-migration.c     |  2 +-
>   block.c               | 32 +++++++++++++++++++++++++++++++-
>   block/mirror.c        |  2 +-
>   include/block/block.h |  7 ++++++-
>   qapi/block-core.json  |  4 +++-
>   5 files changed, 42 insertions(+), 5 deletions(-)

You can keep R-bs on patches which you don't have modified (or only 
contextually, or directly according to what the reviewer made a 
condition for the R-b). Just add them below the S-o-b in the commit message.

Reviewed-by: Max Reitz <address@hidden>