Re: [Qemu-devel] MinGW build

[Stefan Weil]

Am 27.11.2014 um 21:18 schrieb Peter Maydell:
> On 27 November 2014 at 20:09, Stefan Weil <address@hidden> wrote:
>> *nearly means that there are still warnings for format strings in C++
>> code.
> 
> Hmm, do we still have these with the libvixl version we have
> now? If so, could you forward me a copy of them and I'll see
> if I can persuade upstream to fix them...
> 
> thanks
> -- PMM
> 


The libvixl code is correct, but the C++ compiler would need to be
fixed. Here are some examples:

disas/libvixl/a64/disasm-a64.cc:1340:57: warning: unknown conversion
type character ‘l’ in format [-Wformat]
disas/libvixl/a64/disasm-a64.cc:1340:57: warning: too many arguments for
format [-Wformat-extra-args]
disas/libvixl/a64/disasm-a64.cc:1492:42: warning: unknown conversion
type character ‘l’ in format [-Wformat]

That code uses PRIx64, so the format specifier is %llx which is correct.
Obviously the C++ compiler ignores that QEMU uses ANSI format specifiers
(compiler option -D__USE_MINGW_ANSI_STDIO=1) instead of the MS specific
ones.

A simple workaround for QEMU would just suppress -Wformat and
-Wformat-extra-args for C++ code.

Regards
Stefan