qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [2.2 PATCH V2] virtio-net: fix unmap leak


From: Peter Maydell
Subject: Re: [Qemu-devel] [2.2 PATCH V2] virtio-net: fix unmap leak
Date: Fri, 28 Nov 2014 13:05:36 +0000

On 27 November 2014 at 10:04, Jason Wang <address@hidden> wrote:
> virtio_net_handle_ctrl() and other functions that process control vq
> request call iov_discard_front() which will shorten the iov. This will
> lead unmapping in virtqueue_push() leaks mapping.
>
> Fixes this by keeping the original iov untouched and using a temp variable
> in those functions.
>
> Cc: Wen Congyang <address@hidden>
> Cc: Stefano Stabellini <address@hidden>
> Cc: address@hidden
> Signed-off-by: Jason Wang <address@hidden>
> ---
> Changes from V1:
> - Use g_memdup() to simplify codes
> ---
>  hw/net/virtio-net.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Applied to master, thanks.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]