qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv3] block: add event when disk usage exceeds thre


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCHv3] block: add event when disk usage exceeds threshold
Date: Tue, 2 Dec 2014 15:01:17 +0000
User-agent: Mutt/1.5.23 (2014-03-12)

On Fri, Nov 28, 2014 at 01:31:07PM +0100, Francesco Romani wrote:
> @@ -82,6 +83,8 @@ BlockDeviceInfo *bdrv_block_device_info(BlockDriverState 
> *bs)
>          info->iops_size = cfg.op_size;
>      }
>  
> +    info->write_threshold = bdrv_usage_threshold_get(bs);

Overall looks good but I notice that "write_threshold" and
"usage_threshold" are both used.  Please use just one consistently (I
think "write_threshold" is clearer).

Attachment: pgpdqOEIaiBk5.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]