[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv3] block: add event when disk usage exceeds thre
|
From: |
Francesco Romani |
|
Subject: |
Re: [Qemu-devel] [PATCHv3] block: add event when disk usage exceeds threshold |
|
Date: |
Tue, 2 Dec 2014 10:11:29 -0500 (EST) |
----- Original Message -----
> From: "Stefan Hajnoczi" <address@hidden>
> To: "Francesco Romani" <address@hidden>
> Cc: address@hidden, address@hidden, address@hidden, address@hidden
> Sent: Tuesday, December 2, 2014 4:01:17 PM
> Subject: Re: [Qemu-devel] [PATCHv3] block: add event when disk usage exceeds
> threshold
>
> On Fri, Nov 28, 2014 at 01:31:07PM +0100, Francesco Romani wrote:
> > @@ -82,6 +83,8 @@ BlockDeviceInfo *bdrv_block_device_info(BlockDriverState
> > *bs)
> > info->iops_size = cfg.op_size;
> > }
> >
> > + info->write_threshold = bdrv_usage_threshold_get(bs);
>
> Overall looks good but I notice that "write_threshold" and
> "usage_threshold" are both used. Please use just one consistently (I
> think "write_threshold" is clearer).
Agreed. Will use "write_threshold" everywhere, file names included.
Bests,
--
Francesco Romani
RedHat Engineering Virtualization R & D
Phone: 8261328
IRC: fromani