[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layou
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout |
Date: |
Tue, 2 Dec 2014 21:03:45 +0200 |
On Tue, Dec 02, 2014 at 04:41:36PM +0100, Cornelia Huck wrote:
> void virtio_queue_set_num(VirtIODevice *vdev, int n, int num)
> {
> + /*
> + * For virtio-1 devices, the number of buffers may only be
> + * updated if the ring addresses have not yet been set up.
Where does it say that?
> + */
> + if (virtio_has_feature(vdev, VIRTIO_F_VERSION_1) &&
> + vdev->vq[n].vring.desc) {
> + error_report("tried to modify buffer num for virtio-1 device");
> + return;
> + }
> /* Don't allow guest to flip queue between existent and
> * nonexistent states, or to set it to an invalid size.
> */
- [Qemu-devel] [PATCH RFC v5 01/19] linux-headers/virtio_config: Update with VIRTIO_F_VERSION_1, (continued)
- [Qemu-devel] [PATCH RFC v5 01/19] linux-headers/virtio_config: Update with VIRTIO_F_VERSION_1, Cornelia Huck, 2014/12/02
- [Qemu-devel] [PATCH RFC v5 03/19] virtio: feature bit manipulation helpers, Cornelia Huck, 2014/12/02
- [Qemu-devel] [PATCH RFC v5 04/19] virtio: add feature checking helpers, Cornelia Huck, 2014/12/02
- [Qemu-devel] [PATCH RFC v5 05/19] virtio: support more feature bits, Cornelia Huck, 2014/12/02
- [Qemu-devel] [PATCH RFC v5 06/19] virtio: endianness checks for virtio 1.0 devices, Cornelia Huck, 2014/12/02
- [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout, Cornelia Huck, 2014/12/02
- Re: [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout, Michael S. Tsirkin, 2014/12/02
- Re: [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout, Cornelia Huck, 2014/12/02
- Re: [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout, Cornelia Huck, 2014/12/02
- Re: [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout, Cornelia Huck, 2014/12/03
- Re: [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout, Cornelia Huck, 2014/12/03
- Re: [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout, Michael S. Tsirkin, 2014/12/03
- Re: [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout, Cornelia Huck, 2014/12/03
- Re: [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout, Michael S. Tsirkin, 2014/12/03
- Re: [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout, Cornelia Huck, 2014/12/03
[Qemu-devel] [PATCH RFC v5 08/19] dataplane: allow virtio-1 devices, Cornelia Huck, 2014/12/02
[Qemu-devel] [PATCH RFC v5 09/19] s390x/css: Add a callback for when subchannel gets disabled, Cornelia Huck, 2014/12/02
[Qemu-devel] [PATCH RFC v5 12/19] virtio: disallow late feature changes for virtio-1, Cornelia Huck, 2014/12/02
[Qemu-devel] [PATCH RFC v5 11/19] s390x/virtio-ccw: support virtio-1 set_vq format, Cornelia Huck, 2014/12/02