[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ide: Check validity of logical block size
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] ide: Check validity of logical block size |
|
Date: |
Wed, 03 Dec 2014 15:37:23 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Kevin Wolf <address@hidden> writes:
> Our IDE emulation can't handle logical block sizes other than 512. Check
> for it.
I guess this is in part due to the 512 literals sprinkled all over the
IDE code.
> The original assumption was that other values would silently be ignored
> (which is bad enough), but it's not quite true: The physical block size
> is exposed in IDENTIFY DEVICE as a multiple of the logical block size.
> Setting a logical block size therefore also corrupts the physical block
> size (4096/4096 doesn't silently downgrade to 4096/512, but 512/512).
>
> Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>