[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 14/26] qcow2: Use symbolic macros in qcow2_am
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 14/26] qcow2: Use symbolic macros in qcow2_amend_options |
Date: |
Wed, 03 Dec 2014 12:48:14 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 12/03/2014 06:37 AM, Max Reitz wrote:
> qcow2_amend_options() should not compare options against some inline
> strings but rather use the symbolic macros available for each of the
> creation options.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/qcow2.c | 31 ++++++++++++++++---------------
> 1 file changed, 16 insertions(+), 15 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v4 25/26] qcow2: Point to amend function in check, (continued)
[Qemu-devel] [PATCH v4 15/26] iotests: Prepare for refcount_bits option, Max Reitz, 2014/12/03
[Qemu-devel] [PATCH v4 14/26] qcow2: Use symbolic macros in qcow2_amend_options, Max Reitz, 2014/12/03
[Qemu-devel] [PATCH v4 18/26] block: Add opaque value to the amend CB, Max Reitz, 2014/12/03