Re: [Qemu-devel] [PATCH v4 2/6] vmdk: Fix comment to match code of extent lines

[Don Koch]

On Thu, 4 Dec 2014 07:28:30 +0800
Fam Zheng <address@hidden> wrote:

> commit 04d542c8b (vmdk: support vmfs files) added support of VMFS extent
> type but the comment above the changed code is left out. Update the
> comment so they are consistent.
> 
> Signed-off-by: Fam Zheng <address@hidden>
> ---

Reviewed-by: Don Koch <address@hidden>

>  block/vmdk.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/block/vmdk.c b/block/vmdk.c
> index ebb4b70..4ee0aed 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -785,10 +785,12 @@ static int vmdk_parse_extents(const char *desc, 
> BlockDriverState *bs,
>      VmdkExtent *extent;
>  
>      while (*p) {
> -        /* parse extent line:
> +        /* parse extent line in one of below formats:
> +         *
>           * RW [size in sectors] FLAT "file-name.vmdk" OFFSET
> -         * or
>           * RW [size in sectors] SPARSE "file-name.vmdk"
> +         * RW [size in sectors] VMFS "file-name.vmdk"
> +         * RW [size in sectors] VMFSSPARSE "file-name.vmdk"
>           */
>          flat_offset = -1;
>          ret = sscanf(p, "%10s %" SCNd64 " %10s \"%511[^\n\r\"]\" %" SCNd64,
> -- 
> 1.9.3
>