qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v2 0/3] iotests: Fix test 039


From: Max Reitz
Subject: [Qemu-devel] [PATCH v2 0/3] iotests: Fix test 039
Date: Thu, 4 Dec 2014 15:48:59 +0100

Test 039 used to fail because qemu-io -c abort may generate core dumps
even with ulimit -c 0 (and the output then contains "(core dumped)").
Fix this by adding a new qemu-io command "sigraise" which invokes
raise(). Using this command to raise SIGKILL for example does not result
in a core dump, but it still badly crashes qemu-io (as desired).

I am sending this series because we need all tests to work before adding
the check-block target to "make check" (which we will hopefully do
soon).


v2:
- Rewrote patch 1: Overloading "abort" may be somehow technically
  justifyable, but there is no point in grasping at straws when it is
  much easier to just introduce a new command. Therefore, in this
  version, "abort" is no longer overloaded and instead a new command,
  "sigraise", is added (I thought long and hard about that name; I
  thought "raise" to sound too unspecific, so this is what I came up
  with) [Markus]
- Patch 2: Fixed commit message (s/if it is aborted/when it is killed/)
  [Markus]
- Patch 3: %s/abort -S 9/sigraise 9/


git-backport-diff against v1:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/3:[down] 'qemu-io: Add sigraise command'
       ^^^^ wrong, should be:
      [0081] [FC]
002/3:[----] [--] 'iotests: Filter for "Killed" in qemu-io output'
003/3:[0006] [FC] 'iotests: Fix test 039'


Max Reitz (3):
  qemu-io: Add sigraise command
  iotests: Filter for "Killed" in qemu-io output
  iotests: Fix test 039

 qemu-io-cmds.c                   | 46 ++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/039           | 12 ++++++-----
 tests/qemu-iotests/039.out       |  6 +++---
 tests/qemu-iotests/common.filter |  2 +-
 4 files changed, 57 insertions(+), 9 deletions(-)

-- 
1.9.3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]