|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [RFC PATCH v5 07/31] icount: implement icount requesting |
| Date: | Thu, 04 Dec 2014 16:50:58 +0100 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 04/12/2014 12:02, Pavel Dovgaluk wrote: >> > Why do you need to do this if !cpu_can_do_io(cpu)? > We save number of executed instruction when saving interrupt or exception > event. > It leads to the call of cpu_get_instructions_counter() from cpu_exec function > (through several replay functions). It is correct (because no block is > executing > at that moment) but is different to prior usage of icount requests. Why is !cpu_can_do_io(cpu) if no block is executing? I'm not saying the function is wrong, just that it warrants a more thorough review. Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |