Re: [Qemu-devel] [PATCH] spice: fix memory leak

[Gerd Hoffmann]

On Fr, 2014-12-05 at 11:31 +0800, address@hidden wrote:
> From: Gonglei <address@hidden>
> 
> If errors happen for middle items of channel_list,
> qmp_query_spice_channels() return NULL, and varriable
> cur_item going out of scope leaks the storage it points to.
> Let's check for errors in advance avoid memory leak.

I think we can simply turn that into an assert().  The flag is a
compatibility thing for older spice-server versions.  Meanwhile our
minimum spice version requirement is new enough that we should never
ever see this error, and if we do something went very seriously wrong.

cheers,
  Gerd