[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/4] qmp: Introduce blockdev-change-medium
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/4] qmp: Introduce blockdev-change-medium |
Date: |
Fri, 05 Dec 2014 06:25:51 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 12/05/2014 06:18 AM, Max Reitz wrote:
>>
>> Should there be a way to empty a cdrom drive? That is, how do I change
>> a drive from visiting a file to being empty?
>
> Doesn't 'eject' work?
Oh, good point. More cross-referencing documentation work, then :)
At which point, THIS command can keep a mandatory 'filename', and should
probably fail on "" rather than being a synonym to 'eject'.
>
>> Does passing the empty
>> string for mandatory 'filename' do that, or should we be strict and
>> state that filename is optional (omit to empty the drive) and that an
>> empty string as filename is forbidden?
>>
>> Please also improve the documentation in qapi-schema.json to have the
>> 'change' command mention that it is kept for backwards compatibility,
>> but that it is no longer the preferred command and point users to
>> 'blockdev-change-medium'.
>
> And to 'change-vnc-password'. Will do.
>
> Max
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v2 4/4] hmp: Add read-only option to change command, Max Reitz, 2014/12/05
Re: [Qemu-devel] [PATCH v2 0/4] blockdev: Add blockdev-change-medium with read-only option, Eric Blake, 2014/12/05
Re: [Qemu-devel] [PATCH v2 0/4] blockdev: Add blockdev-change-medium with read-only option, Markus Armbruster, 2014/12/05