Re: [Qemu-devel] [PATCH 2/4] target-i386: add VME to all CPUs

[Paolo Bonzini]

On 05/12/2014 19:32, Eduardo Habkost wrote:
>> > vm86 mode extensions date back to the 486.  All models should have
>> > them.
>> > 
>> > Signed-off-by: Paolo Bonzini <address@hidden>
> TCG doesn't support VME (that's probably why we didn't have it set on
> most CPU models), and I would like to eventually make check/enforce mode
> work on TCG as well.
> 
> I was going to suggest adding it to kvm_default_features instead, but as
> we have existing models that have CPUID_VME already, let's be consistent
> and add it to all of them (and deal with TCG check/enforce mode later,
> if necessary).

Yes, my thoughts as well.  The weird thing is that we have it on the
really old models that TCG ought to emulate almost completely, but not
on the newer ones...

We can add tcg_default_unset_features too.

Paolo