[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vnc-enc-tight: fix Arguments in wrong order
From: |
Gonglei |
Subject: |
Re: [Qemu-devel] [PATCH] vnc-enc-tight: fix Arguments in wrong order |
Date: |
Mon, 8 Dec 2014 19:43:33 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 |
On 2014/11/20 17:07, Gonglei (Arei) wrote:
> From: Gonglei <address@hidden>
>
> Arguments in wrong order (SWAPPED_ARGUMENTS)
> The positions of arguments in the call to
> tight_fill_palette do not match the ordering of the parameters:
> &fg is passed to bg
> &bg is passed to fg
>
> Cc: Gerd Hoffmann <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> ---
> ui/vnc-enc-tight.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
> index 3d1b5cd..9a9ddf2 100644
> --- a/ui/vnc-enc-tight.c
> +++ b/ui/vnc-enc-tight.c
> @@ -1489,7 +1489,7 @@ static int send_sub_rect(VncState *vs, int x, int y,
> int w, int h)
> }
> #endif
>
> - colors = tight_fill_palette(vs, x, y, w * h, &fg, &bg, &palette);
> + colors = tight_fill_palette(vs, x, y, w * h, &bg, &fg, &palette);
>
> #ifdef CONFIG_VNC_JPEG
> if (allow_jpeg && vs->tight.quality != (uint8_t)-1) {
Ping...
Regards,
-Gonglei
- Re: [Qemu-devel] [PATCH] vnc-enc-tight: fix Arguments in wrong order,
Gonglei <=