[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] target-arm: Check error conditions on kvm_ar
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2] target-arm: Check error conditions on kvm_arm_reset_vcpu |
Date: |
Mon, 8 Dec 2014 11:59:34 +0000 |
On 8 December 2014 at 11:58, Christoffer Dall
<address@hidden> wrote:
> On Mon, Dec 08, 2014 at 12:53:50PM +0100, Christoffer Dall wrote:
>> When resetting a VCPU we currently call both kvm_arm_vcpu_init() and
>> write_kvmstate_to_list(), both of which can fail, but we never check the
>> return value.
>>
>> The only choice here is to print an error an exit if the calls fail.
>>
>> Signed-off-by: Christoffer Dall <address@hidden>
>> ---
>> Changes [v1 -> v2]:
>> - Rebased onto Peter Maydell's "support migration/save/load on AArch64 CPUs"
>> series.
>
> Forgot to mention that I also changed strerror(ret) to strerror(-ret).
That's ok, I forgot to check that you had when I reviewed this :-)
-- PMM