Re: [Qemu-devel] [PATCH 3/9] pc: acpi-build: cleanup AcpiPmInfo initialization

[Igor Mammedov]

On Mon, 8 Dec 2014 23:03:02 +0200
"Michael S. Tsirkin" <address@hidden> wrote:

> On Mon, Dec 08, 2014 at 04:08:02PM +0000, Igor Mammedov wrote:
> > zero initialize AcpiPmInfo struct to reduce code bloat
> > a little bit.
> > 
> > Signed-off-by: Igor Mammedov <address@hidden>
> 
> I generally prefer explicit initialization, but
> it's a matter of taste.
I did this since it saves some LOCs and will save even
more later with patches for dynamic _CRS.

> > ---
> >  hw/i386/acpi-build.c | 8 ++------
> >  1 file changed, 2 insertions(+), 6 deletions(-)
> > 
> > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> > index 1fb92e5..f5ec66a 100644
> > --- a/hw/i386/acpi-build.c
> > +++ b/hw/i386/acpi-build.c
> > @@ -161,6 +161,8 @@ static void acpi_get_pm_info(AcpiPmInfo *pm)
> >      Object *obj = NULL;
> >      QObject *o;
> >  
> > +    memset(pm, 0, sizeof(*pm));
> > +
> >      if (piix) {
> >          obj = piix;
> >      }
> > @@ -173,22 +175,16 @@ static void acpi_get_pm_info(AcpiPmInfo *pm)
> >      o = object_property_get_qobject(obj, ACPI_PM_PROP_S3_DISABLED, NULL);
> >      if (o) {
> >          pm->s3_disabled = qint_get_int(qobject_to_qint(o));
> > -    } else {
> > -        pm->s3_disabled = false;
> >      }
> >      qobject_decref(o);
> >      o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_DISABLED, NULL);
> >      if (o) {
> >          pm->s4_disabled = qint_get_int(qobject_to_qint(o));
> > -    } else {
> > -        pm->s4_disabled = false;
> >      }
> >      qobject_decref(o);
> >      o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_VAL, NULL);
> >      if (o) {
> >          pm->s4_val = qint_get_int(qobject_to_qint(o));
> > -    } else {
> > -        pm->s4_val = false;
> >      }
> >      qobject_decref(o);
> >  
> > -- 
> > 1.8.3.1
>