[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 03/10] block: Introduce bdrv_dirty_bitmap_gra
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v9 03/10] block: Introduce bdrv_dirty_bitmap_granularity() |
Date: |
Tue, 9 Dec 2014 16:10:45 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Dec 01, 2014 at 03:30:09PM -0500, John Snow wrote:
> diff --git a/include/block/block.h b/include/block/block.h
> index 066ded6..f180f93 100644
> --- a/include/block/block.h
> +++ b/include/block/block.h
> @@ -440,6 +440,8 @@ void bdrv_dirty_bitmap_make_anon(BlockDriverState *bs,
> BdrvDirtyBitmap *bitmap);
> void bdrv_release_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap
> *bitmap);
> BlockDirtyInfoList *bdrv_query_dirty_bitmaps(BlockDriverState *bs);
> uint64_t bdrv_dbm_calc_def_granularity(BlockDriverState *bs);
> +int64_t bdrv_dirty_bitmap_granularity(BlockDriverState *bs,
> + BdrvDirtyBitmap *bitmap);
This looks weird now. The default granularity has uint64_t type but the
actual granularity has int64_t.
Please make them consistent.
pgphhDgbzKnP5.pgp
Description: PGP signature
- [Qemu-devel] [PATCH v9 00/10] block: Incremental backup series, John Snow, 2014/12/01
- [Qemu-devel] [PATCH v9 01/10] qapi: Add optional field "name" to block dirty bitmap, John Snow, 2014/12/01
- [Qemu-devel] [PATCH v9 03/10] block: Introduce bdrv_dirty_bitmap_granularity(), John Snow, 2014/12/01
- Re: [Qemu-devel] [PATCH v9 03/10] block: Introduce bdrv_dirty_bitmap_granularity(),
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v9 04/10] hbitmap: Add hbitmap_copy, John Snow, 2014/12/01
- [Qemu-devel] [PATCH v9 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove, John Snow, 2014/12/01
- Re: [Qemu-devel] [PATCH v9 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove, Eric Blake, 2014/12/01
- Re: [Qemu-devel] [PATCH v9 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove, Stefan Hajnoczi, 2014/12/09
- Re: [Qemu-devel] [PATCH v9 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove, Markus Armbruster, 2014/12/10
- Re: [Qemu-devel] [PATCH v9 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove, Stefan Hajnoczi, 2014/12/12
- Re: [Qemu-devel] [PATCH v9 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove, Markus Armbruster, 2014/12/15
- Re: [Qemu-devel] [PATCH v9 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove, John Snow, 2014/12/17
- Re: [Qemu-devel] [PATCH v9 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove, Markus Armbruster, 2014/12/17