Re: [Qemu-devel] [PATCH v4 02/26] qcow2: Add refcount_bits to format-specific info

[Stefan Hajnoczi]

On Wed, Dec 03, 2014 at 02:37:22PM +0100, Max Reitz wrote:
> Add the bit width of every refcount entry to the format-specific
> information.
> 
> In contrast to lazy_refcounts and the corrupt flag, this should be
> always emitted, even for compat=0.10 although it does not support any
> refcount width other than 16 bits. This is because if a boolean is
> optional, one normally assumes it to be false when omitted; but if an
> integer is not specified, it is rather difficult to guess its value.
> 
> This new field breaks some test outputs, fix them.
> 
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  block/qcow2.c              |  4 +++-
>  qapi/block-core.json       |  5 ++++-
>  tests/qemu-iotests/060.out |  1 +
>  tests/qemu-iotests/065     | 23 +++++++++++++++--------
>  tests/qemu-iotests/067.out |  5 +++++
>  tests/qemu-iotests/082.out |  7 +++++++
>  tests/qemu-iotests/089.out |  2 ++
>  7 files changed, 37 insertions(+), 10 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

pgpCCHm7DS6UU.pgp
Description: PGP signature