[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/4] pc: add 2.3 machine types
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/4] pc: add 2.3 machine types |
|
Date: |
Wed, 10 Dec 2014 13:48:23 -0200 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Dec 10, 2014 at 04:08:38PM +0100, Paolo Bonzini wrote:
> On 10/12/2014 14:12, Eduardo Habkost wrote:
> >> > +#define PC_Q35_2_2_MACHINE_OPTIONS PC_Q35_2_3_MACHINE_OPTIONS
> > I don't know which approach I prefer (I would be happy with either), but
> > why the difference?
>
> I'm just mimicking what's around:
>
> #define PC_Q35_2_0_MACHINE_OPTIONS PC_Q35_2_1_MACHINE_OPTIONS
Whatever you see on pc_q35.c, it is also present on pc_piix.c:
#define PC_I440FX_2_0_MACHINE_OPTIONS PC_I440FX_2_1_MACHINE_OPTIONS
Both approaches are OK to me, I just don't see why you decided to make
pc_piix.c and pc_q35.c different.
--
Eduardo
[Qemu-devel] [PATCH v2 2/4] target-i386: add VME to all CPUs, Paolo Bonzini, 2014/12/10
[Qemu-devel] [PATCH v2 3/4] target-i386: add f16c and rdrand to Haswell and Broadwell, Paolo Bonzini, 2014/12/10
[Qemu-devel] [PATCH v2 4/4] target-i386: add Ivy Bridge CPU model, Paolo Bonzini, 2014/12/10