qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/1] Sort include/qemu/typedefs.h


From: Alex Bennée
Subject: Re: [Qemu-devel] [PATCH 1/1] Sort include/qemu/typedefs.h
Date: Thu, 11 Dec 2014 13:24:33 +0000

Dr. David Alan Gilbert (git) <address@hidden> writes:

> From: "Dr. David Alan Gilbert" <address@hidden>
>
> Mainly to make it less likely to conflict during merges.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>

I'm happy with the idea (having been adding stuff recently). However
have you:

a) checked for typedefs no longer used by the wider code base
b) audited for others using opaque types pulling in full definitions?

Otherwise:

Reviewed-by: Alex Bennée <address@hidden>

Cheers,

-- 
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]