[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 13/26] qcow2: refcount_order parameter for qc
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v4 13/26] qcow2: refcount_order parameter for qcow2_create2 |
Date: |
Thu, 11 Dec 2014 13:41:47 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Dec 03, 2014 at 02:37:33PM +0100, Max Reitz wrote:
> Add a refcount_order parameter to qcow2_create2(), use that value for
> the image header and for calculating the size required for
> preallocation.
>
> For now, always pass 4.
>
> This addition requires changes to the calculation of the file size for
> the "full" and "falloc" preallocation modes. That in turn is a nice
> opportunity to add a comment about that calculation not necessarily
> being exact (and that being intentional).
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/qcow2.c | 46 +++++++++++++++++++++++++++++++++++-----------
> 1 file changed, 35 insertions(+), 11 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
pgpguT5OF3_s6.pgp
Description: PGP signature
- Re: [Qemu-devel] [PATCH v4 09/26] qcow2: Helper for refcount array reallocation, (continued)
- [Qemu-devel] [PATCH v4 10/26] qcow2: Helper function for refcount modification, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 11/26] qcow2: More helpers for refcount modification, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 12/26] qcow2: Open images with refcount order != 4, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 13/26] qcow2: refcount_order parameter for qcow2_create2, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 17/26] progress: Allow regressing progress, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 16/26] qcow2: Allow creation with refcount order != 4, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 19/26] qcow2: Use error_report() in qcow2_amend_options(), Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 20/26] qcow2: Use abort() instead of assert(false), Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 21/26] qcow2: Split upgrade/downgrade paths for amend, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 22/26] qcow2: Use intermediate helper CB for amend, Max Reitz, 2014/12/03