Re: [Qemu-devel] [PATCH v4 15/26] iotests: Prepare for refcount_bits option

[Stefan Hajnoczi]

On Wed, Dec 03, 2014 at 02:37:35PM +0100, Max Reitz wrote:
> Some tests do not work well with certain refcount widths (i.e. you
> cannot create internal snapshots with refcount_bits=1), so make those
> widths unsupported.
> 
> Furthermore, add another filter to _filter_img_create in common.filter
> which filters out the refcount_bits value.
> 
> This is necessary for test 079, which does actually work with any
> refcount width, but invoking qemu-img directly leads to the
> refcount_bits value being visible in the output; use _make_test_img
> instead which will filter it out.
> 
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  tests/qemu-iotests/007           |  3 +++
>  tests/qemu-iotests/015           |  2 ++
>  tests/qemu-iotests/026           |  7 +++++++
>  tests/qemu-iotests/029           |  2 ++
>  tests/qemu-iotests/051           |  3 +++
>  tests/qemu-iotests/058           |  2 ++
>  tests/qemu-iotests/067           |  2 ++
>  tests/qemu-iotests/079           | 10 ++--------
>  tests/qemu-iotests/079.out       | 38 ++++++++++----------------------------
>  tests/qemu-iotests/080           |  2 ++
>  tests/qemu-iotests/089           |  2 ++
>  tests/qemu-iotests/108           |  2 ++
>  tests/qemu-iotests/common.filter |  3 ++-
>  13 files changed, 41 insertions(+), 37 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

pgpov3SdxvjHw.pgp
Description: PGP signature