[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/10] sdl2: move sdl2_2d_refresh to sdl2-2d.c
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 10/10] sdl2: move sdl2_2d_refresh to sdl2-2d.c |
Date: |
Fri, 12 Dec 2014 11:45:36 +0100 |
On Do, 2014-12-11 at 16:19 +0100, Max Reitz wrote:
> On 2014-12-11 at 11:49, Gerd Hoffmann wrote:
> > Now that common event handling code is split off, we can move
> > over sdl_refresh to sdl2-2d.c, and rename it to sdl2_2d_refresh.
> >
> > Signed-off-by: Gerd Hoffmann <address@hidden>
> > ---
> > include/ui/sdl2.h | 1 +
> > ui/sdl2-2d.c | 9 +++++++++
> > ui/sdl2.c | 10 +---------
> > 3 files changed, 11 insertions(+), 9 deletions(-)
> >
> > diff --git a/include/ui/sdl2.h b/include/ui/sdl2.h
> > index 27b3132..9e9a92d 100644
> > --- a/include/ui/sdl2.h
> > +++ b/include/ui/sdl2.h
> > @@ -23,4 +23,5 @@ void sdl2_2d_update(DisplayChangeListener *dcl,
> > int x, int y, int w, int h);
> > void sdl2_2d_switch(DisplayChangeListener *dcl,
> > DisplaySurface *new_surface);
> > +void sdl2_2d_refresh(DisplayChangeListener *dcl);
> > void sdl2_2d_redraw(struct sdl2_console *scon);
> > diff --git a/ui/sdl2-2d.c b/ui/sdl2-2d.c
> > index 40a552c..9c60075 100644
> > --- a/ui/sdl2-2d.c
> > +++ b/ui/sdl2-2d.c
> > @@ -103,6 +103,15 @@ void sdl2_2d_switch(DisplayChangeListener *dcl,
> > sdl2_2d_redraw(scon);
> > }
> >
> > +void sdl2_2d_refresh(DisplayChangeListener *dcl)
> > +{
> > + struct sdl2_console *scon = container_of(dcl, struct sdl2_console,
> > dcl);
> > +
> > + assert(!scon->opengl);
>
> This doesn't compile for me because this flag is not added by this series.
Fixed.
cheers,
Gerd
- [Qemu-devel] [PATCH 00/10] sdl2: fixes, cleanups and opengl preparation., Gerd Hoffmann, 2014/12/11
- [Qemu-devel] [PATCH 02/10] sdl2: rename sdl2_state to sdl2_console, move to header file, Gerd Hoffmann, 2014/12/11
- [Qemu-devel] [PATCH 10/10] sdl2: move sdl2_2d_refresh to sdl2-2d.c, Gerd Hoffmann, 2014/12/11
- [Qemu-devel] [PATCH 04/10] sdl2: turn on keyboard grabs, Gerd Hoffmann, 2014/12/11
- [Qemu-devel] [PATCH 06/10] sdl2: overhaul window size handling, Gerd Hoffmann, 2014/12/11
- [Qemu-devel] [PATCH 09/10] sdl2: factor out sdl2_poll_events, Gerd Hoffmann, 2014/12/11
- [Qemu-devel] [PATCH 05/10] sdl2: move sdl_update to new sdl2-2d.c, Gerd Hoffmann, 2014/12/11