[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/7] fw_cfg: introduce the "data_memwidth" pr
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/7] fw_cfg: introduce the "data_memwidth" property |
Date: |
Fri, 12 Dec 2014 13:41:54 +0000 |
On 12 December 2014 at 13:39, Laszlo Ersek <address@hidden> wrote:
> I considered "locking down" the new interface, and preventing callers
> from passing in any IO ports when they want a wider MMIO data register.
> I didn't do that because someone might want a wider ioport mapping at
> some point (although no current such user exists and I couldn't name
> what the advantage would be in it). Unless you use the combined thing,
> the wide data register should work with the ioport mapping too.
>
> The combined case I thought to leave simply undefined.
>
> If you want, I can set an error, but then I'd prefer to prevent callers
> from passing IO ports through the new data_memwidth-taking functions.
Yeah, I don't think we need to make the combined case work, but it
does seem worth at least making it fail cleanly if anybody tries it,
rather than silently doing the wrong thing.
-- PMM
- [Qemu-devel] [PATCH v3 0/7] fw_cfg, bootorder, and UEFI+'-kernel' on arm/virt, Laszlo Ersek, 2014/12/08
- [Qemu-devel] [PATCH v3 3/7] fw_cfg: expose the "data_memwidth" prop with fw_cfg_init_data_memwidth(), Laszlo Ersek, 2014/12/08
- [Qemu-devel] [PATCH v3 4/7] arm: add fw_cfg to "virt" board, Laszlo Ersek, 2014/12/08
- [Qemu-devel] [PATCH v3 5/7] hw/loader: split out load_image_gzipped_buffer(), Laszlo Ersek, 2014/12/08
- [Qemu-devel] [PATCH v3 6/7] hw/arm: pass pristine kernel image to guest firmware over fw_cfg, Laszlo Ersek, 2014/12/08