[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 5/7] hw/loader: split out load_image_gzipped_
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH v3 5/7] hw/loader: split out load_image_gzipped_buffer() |
Date: |
Fri, 12 Dec 2014 14:43:38 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 12/12/14 14:11, Peter Maydell wrote:
> On 9 December 2014 at 01:13, Laszlo Ersek <address@hidden> wrote:
>> In the next patch we'd like to reuse the image decompression facility
>> without installing the output as a ROM at a specific guest-phys address.
>>
>> In addition, expose LOAD_IMAGE_MAX_GUNZIP_BYTES, because that's a
>> straightforward "max_sz" argument for the new load_image_gzipped_buffer().
>>
>> Signed-off-by: Laszlo Ersek <address@hidden>
>> ---
>
>> +int load_image_gzipped(const char *filename, hwaddr addr, uint64_t max_sz)
>> +{
>> + int bytes;
>> + uint8_t *data;
>> +
>> + bytes = load_image_gzipped_buffer (filename, max_sz, &data);
>
> Doesn't checkpatch complain about the space before the "(" here?
(Checkpatch? What's that? :))
It sure does.
WARNING: space prohibited between function name and open parenthesis '('
Obviously, the edk2 coding style *requires* that damn space. I got so
used to it that it slipped in here.
Thanks!
Laszlo
>
> Otherwise:
> Reviewed-by: Peter Maydell <address@hidden>
>
> -- PMM
>
- [Qemu-devel] [PATCH v3 2/7] fw_cfg: introduce the "data_memwidth" property, (continued)
- [Qemu-devel] [PATCH v3 3/7] fw_cfg: expose the "data_memwidth" prop with fw_cfg_init_data_memwidth(), Laszlo Ersek, 2014/12/08
- [Qemu-devel] [PATCH v3 4/7] arm: add fw_cfg to "virt" board, Laszlo Ersek, 2014/12/08
- [Qemu-devel] [PATCH v3 5/7] hw/loader: split out load_image_gzipped_buffer(), Laszlo Ersek, 2014/12/08
- [Qemu-devel] [PATCH v3 6/7] hw/arm: pass pristine kernel image to guest firmware over fw_cfg, Laszlo Ersek, 2014/12/08
- Re: [Qemu-devel] [PATCH v3 6/7] hw/arm: pass pristine kernel image to guest firmware over fw_cfg, Peter Maydell, 2014/12/12
- Re: [Qemu-devel] [PATCH v3 6/7] hw/arm: pass pristine kernel image to guest firmware over fw_cfg, Laszlo Ersek, 2014/12/12
- Re: [Qemu-devel] [PATCH v3 6/7] hw/arm: pass pristine kernel image to guest firmware over fw_cfg, Peter Maydell, 2014/12/12
- Re: [Qemu-devel] [PATCH v3 6/7] hw/arm: pass pristine kernel image to guest firmware over fw_cfg, Laszlo Ersek, 2014/12/12
- Re: [Qemu-devel] [PATCH v3 6/7] hw/arm: pass pristine kernel image to guest firmware over fw_cfg, Richard W.M. Jones, 2014/12/12
- Re: [Qemu-devel] [PATCH v3 6/7] hw/arm: pass pristine kernel image to guest firmware over fw_cfg, Laszlo Ersek, 2014/12/12
[Qemu-devel] [PATCH v3 7/7] hw/arm/virt: enable passing of EFI-stubbed kernel to guest UEFI firmware, Laszlo Ersek, 2014/12/08