[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] disas/mips: remove unused mips16_to_32_reg_
|
From: |
Leon Alrae |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/4] disas/mips: remove unused mips16_to_32_reg_map[] |
|
Date: |
Fri, 12 Dec 2014 14:28:36 +0000 |
|
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 12/12/2014 12:25, Peter Maydell wrote:
> On 12 December 2014 at 09:30, Leon Alrae <address@hidden> wrote:
>> The array was "used" in a block of code which has never been enabled.
>> Therefore
>> removing the array as well as 700 lines of never used code.
>
> That's quite a lot to remove -- are you sure we're never going to want
> to disassemble mips16 insns in future?
I quickly tried to enable it but it doesn't seem to be complete. For
example it requires "extern const struct mips_opcode mips16_opcodes[]"
which isn't anywhere in the codebase. Moreover, according to the git
blame it has always been disabled since 2005 thus in my opinion there is
no point in keeping this code. I do want to disassemble mips16 insns, if
someone has proper implementation I'm more than happy to include it.
Regards,
Leon