Re: [Qemu-devel] [PATCH v3 0/3] iotests: Fix test 039

[Stefan Hajnoczi]

On Mon, Dec 08, 2014 at 10:48:09AM +0100, Max Reitz wrote:
> Test 039 used to fail because qemu-io -c abort may generate core dumps
> even with ulimit -c 0 (and the output then contains "(core dumped)").
> Fix this by adding a new qemu-io command "sigraise" which invokes
> raise(). Using this command to raise SIGKILL for example does not result
> in a core dump, but it still badly crashes qemu-io (as desired).
> 
> I am sending this series because we need all tests to work before adding
> the check-block target to "make check" (which we will hopefully do
> soon).
> 
> 
> v3:
> - Patch 1:
>   - s/allows to raise/allows raising/ [Eric]
>   - %s/Unix signal/signal/g [Markus]
>   - Use SIGTERM instead of SIGKILL in the example, and don't hardcode
>     its value [Markus]
> - Patch 3:
>   - Fix commit message (should have been "sigraise 9" instead of
>     "abort -S 9", and now it's "sigraise $(kill -l KILL)") [Fam]
>   - As hinted above, use "sigraise $(kill -l KILL)" instead of
>     hardcoding the value 9 for SIGKILL [Markus]
> 
> 
> git-backport-diff against v2:
> 
> Key:
> [----] : patches are identical
> [####] : number of functional differences between upstream/downstream patch
> [down] : patch is downstream-only
> The flags [FC] indicate (F)unctional and (C)ontextual differences, 
> respectively
> 
> 001/3:[0008] [FC] 'qemu-io: Add sigraise command'
> 002/3:[----] [--] 'iotests: Filter for "Killed" in qemu-io output'
> 003/3:[0012] [FC] 'iotests: Fix test 039'
> 
> 
> Max Reitz (3):
>   qemu-io: Add sigraise command
>   iotests: Filter for "Killed" in qemu-io output
>   iotests: Fix test 039
> 
>  qemu-io-cmds.c                   | 46 
> ++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/039           | 18 +++++++++++-----
>  tests/qemu-iotests/039.out       |  6 +++---
>  tests/qemu-iotests/common.filter |  2 +-
>  4 files changed, 63 insertions(+), 9 deletions(-)
> 
> -- 
> 1.9.3
> 
> 

Thanks, applied to my block-next tree:
https://github.com/stefanha/qemu/commits/block-next

Stefan

pgpCrP24FrwWf.pgp
Description: PGP signature