[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 10/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg
From: |
minyard |
Subject: |
[Qemu-devel] [PATCH 10/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg |
Date: |
Fri, 12 Dec 2014 13:15:45 -0600 |
From: Corey Minyard <address@hidden>
Postpone the addition of the ACPI and SMBIOS tables until after
device initialization. This allows devices to add entries to these
tables.
Signed-off-by: Corey Minyard <address@hidden>
---
hw/i386/pc.c | 58 ++++++++++++++++++++++++++++++++++++++++------------------
1 file changed, 40 insertions(+), 18 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index f31d55e..831d421 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -639,11 +639,45 @@ static unsigned int pc_apic_id_limit(unsigned int
max_cpus)
return x86_cpu_apic_id_from_index(max_cpus - 1) + 1;
}
-static FWCfgState *bochs_bios_init(void)
+struct pc_bios_post_init {
+ Notifier post_init;
+ void *fw_cfg;
+};
+static struct pc_bios_post_init post_init;
+
+/* Add the ACPI and SMBIOS tables after all the hardware has been initialized.
+ * This gives devices a chance to add to those tables.
+ */
+static void pc_bios_post_initfn(Notifier *n, void *opaque)
{
- FWCfgState *fw_cfg;
+ struct pc_bios_post_init *p = container_of(n, struct pc_bios_post_init,
+ post_init);
uint8_t *smbios_tables, *smbios_anchor;
size_t smbios_tables_len, smbios_anchor_len;
+ FWCfgState *fw_cfg = p->fw_cfg;
+
+ smbios_tables = smbios_get_table_legacy(&smbios_tables_len);
+ if (smbios_tables) {
+ fw_cfg_add_bytes(fw_cfg, FW_CFG_SMBIOS_ENTRIES,
+ smbios_tables, smbios_tables_len);
+ }
+
+ smbios_get_tables(&smbios_tables, &smbios_tables_len,
+ &smbios_anchor, &smbios_anchor_len);
+ if (smbios_anchor) {
+ fw_cfg_add_file(fw_cfg, "etc/smbios/smbios-tables",
+ smbios_tables, smbios_tables_len);
+ fw_cfg_add_file(fw_cfg, "etc/smbios/smbios-anchor",
+ smbios_anchor, smbios_anchor_len);
+ }
+
+ fw_cfg_add_bytes(fw_cfg, FW_CFG_ACPI_TABLES,
+ acpi_tables, acpi_tables_len);
+}
+
+static FWCfgState *bochs_bios_init(void)
+{
+ FWCfgState *fw_cfg;
uint64_t *numa_fw_cfg;
int i, j;
unsigned int apic_id_limit = pc_apic_id_limit(max_cpus);
@@ -666,24 +700,8 @@ static FWCfgState *bochs_bios_init(void)
fw_cfg_add_i16(fw_cfg, FW_CFG_MAX_CPUS, (uint16_t)apic_id_limit);
fw_cfg_add_i32(fw_cfg, FW_CFG_ID, 1);
fw_cfg_add_i64(fw_cfg, FW_CFG_RAM_SIZE, (uint64_t)ram_size);
- fw_cfg_add_bytes(fw_cfg, FW_CFG_ACPI_TABLES,
- acpi_tables, acpi_tables_len);
fw_cfg_add_i32(fw_cfg, FW_CFG_IRQ0_OVERRIDE, kvm_allows_irq0_override());
- smbios_tables = smbios_get_table_legacy(&smbios_tables_len);
- if (smbios_tables) {
- fw_cfg_add_bytes(fw_cfg, FW_CFG_SMBIOS_ENTRIES,
- smbios_tables, smbios_tables_len);
- }
-
- smbios_get_tables(&smbios_tables, &smbios_tables_len,
- &smbios_anchor, &smbios_anchor_len);
- if (smbios_anchor) {
- fw_cfg_add_file(fw_cfg, "etc/smbios/smbios-tables",
- smbios_tables, smbios_tables_len);
- fw_cfg_add_file(fw_cfg, "etc/smbios/smbios-anchor",
- smbios_anchor, smbios_anchor_len);
- }
fw_cfg_add_bytes(fw_cfg, FW_CFG_E820_TABLE,
&e820_reserve, sizeof(e820_reserve));
@@ -714,6 +732,10 @@ static FWCfgState *bochs_bios_init(void)
(1 + apic_id_limit + nb_numa_nodes) *
sizeof(*numa_fw_cfg));
+ post_init.fw_cfg = fw_cfg;
+ post_init.post_init.notify = pc_bios_post_initfn;
+ qemu_add_machine_init_done_notifier(&post_init.post_init);
+
return fw_cfg;
}
--
1.8.3.1
- [Qemu-devel] [PATCH 00/16] Add an IPMI device to qemu, minyard, 2014/12/12
- [Qemu-devel] [PATCH 01/16] Add a base IPMI interface, minyard, 2014/12/12
- [Qemu-devel] [PATCH 02/16] ipmi: Add a PC ISA type structure, minyard, 2014/12/12
- [Qemu-devel] [PATCH 03/16] ipmi: Add a KCS low-level interface, minyard, 2014/12/12
- [Qemu-devel] [PATCH 04/16] ipmi: Add a BT low-level interface, minyard, 2014/12/12
- [Qemu-devel] [PATCH 05/16] ipmi: Add a local BMC simulation, minyard, 2014/12/12
- [Qemu-devel] [PATCH 06/16] ipmi: Add an external connection simulation interface, minyard, 2014/12/12
- [Qemu-devel] [PATCH 07/16] ipmi: Add tests, minyard, 2014/12/12
- [Qemu-devel] [PATCH 08/16] ipmi: Add documentation, minyard, 2014/12/12
- [Qemu-devel] [PATCH 09/16] ipmi: Add migration capability to the IPMI device., minyard, 2014/12/12
- [Qemu-devel] [PATCH 10/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg,
minyard <=
- [Qemu-devel] [PATCH 11/16] smbios: Add a function to directly add an entry, minyard, 2014/12/12
- [Qemu-devel] [PATCH 12/16] ipmi: Add SMBIOS table entry, minyard, 2014/12/12
- [Qemu-devel] [PATCH 13/16] acpi: Add a way to extend tables, minyard, 2014/12/12
- [Qemu-devel] [PATCH 14/16] acpi: Add table construction tools, minyard, 2014/12/12
- [Qemu-devel] [PATCH 15/16] ipmi: Add ACPI table entries for BMCs, minyard, 2014/12/12
- [Qemu-devel] [PATCH 16/16] ipmi: Add a thread to better simulate a BMC, minyard, 2014/12/12
- Re: [Qemu-devel] [PATCH 00/16] Add an IPMI device to qemu, Paolo Bonzini, 2014/12/15