Re: [Qemu-devel] [PATCH 3/8] target-tricore: Add instructions of RR opcode format, that have 0xf as the first opcode

[Richard Henderson]

On 12/12/2014 09:31 AM, Bastian Koppelmann wrote:
> +DEF_HELPER_1(clo, i32, i32)
> +DEF_HELPER_1(clo_h, i32, i32)
> +DEF_HELPER_1(clz, i32, i32)
> +DEF_HELPER_1(clz_h, i32, i32)
> +DEF_HELPER_1(cls, i32, i32)
> +DEF_HELPER_1(cls_h, i32, i32)
> +/* sh */
> +DEF_HELPER_2(sh, i32, i32, i32)
> +DEF_HELPER_2(sh_h, i32, i32, i32)

I don't think it's come up so far, since most of your helpers have been
complex, and have been modifying PSW bits.  But you should annotate these with
DEF_HELPER_FLAGS so that TCG knows that there are no side effects.

I do wonder about expanding helper_sh inline, but we can do that later.


r~